Skip to content

chore: set GITHUB_AUTH_TOKEN for phive#586

Closed
datamweb wants to merge 2 commits intocodeigniter4:developfrom
datamweb:fix-deptract-ratelimit
Closed

chore: set GITHUB_AUTH_TOKEN for phive#586
datamweb wants to merge 2 commits intocodeigniter4:developfrom
datamweb:fix-deptract-ratelimit

Conversation

@datamweb
Copy link
Copy Markdown
Collaborator

@datamweb datamweb commented Jan 7, 2023

ref: codeigniter4/CodeIgniter4#7016

Run sudo phive --no-progress install --global --trust-gpg-keys B8F640134AB1782E,A98E898BB53EB748 qossmic/deptrac
Phive 0.15.2 - Copyright (C) 2015-2023 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
Warning:  Github API Rate Limit exceeded - cannot resolve "qossmic/deptrac"
Downloading https://gitlab.com/api/v4/projects/qossmic%2Fdeptrac/releases/
Fetching repository list
Downloading https://phar.io/data/repositories.xml
Error:    Could not resolve requested PHAR qossmic/deptrac

Error: Process completed with exit code 4.

see https://github.com/datamweb/shield/actions/runs/3862351738/jobs/6583866759

@datamweb datamweb added the github_actions Pull requests that update GitHub Actions code label Jan 7, 2023
@datamweb
Copy link
Copy Markdown
Collaborator Author

datamweb commented Jan 7, 2023

It doesn't seem like the right solution to solve the problem. see:

https://github.com/codeigniter4/shield/actions/runs/3862455954/jobs/6584038136

kenjis
kenjis reviewed Jan 7, 2023
View reviewed changes
Comment thread .github/workflows/deptrac.yml Outdated
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jan 7, 2023

It is true that ”Github API Rate Limit exceeded” was reported even if GITHUB_AUTH_TOKEN is set.

https://github.com/codeigniter4/shield/actions/runs/3862455954/jobs/6584038136

Run sudo phive --no-progress install --global --trust-gpg-keys B8F640134AB1782E,A98E898BB53EB748 qossmic/deptrac
  sudo phive --no-progress install --global --trust-gpg-keys B8F640134AB1782E,A98E898BB53EB748 qossmic/deptrac
  deptrac analyze --cache-file=build/deptrac.cache
  shell: /usr/bin/bash -e {0}
  env:
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
    COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
    COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
    GITHUB_AUTH_TOKEN: ***
Phive 0.15.2 - Copyright (C) 2015-2023 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
Warning:  Github API Rate Limit exceeded - cannot resolve "qossmic/deptrac"
Downloading https://gitlab.com/api/v4/projects/qossmic%2Fdeptrac/releases/
Fetching repository list
Downloading https://phar.io/data/repositories.xml
Error:    Could not resolve requested PHAR qossmic/deptrac

Error: Process completed with exit code 4.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jan 8, 2023

Something wrong with this PR.
Screenshot 2023-01-09 8 55 33

@paulbalandan
Copy link
Copy Markdown
Member

paulbalandan commented Jan 9, 2023

I can see the same. Maybe line 75 has extra whitespaces instead of an empty blank line.

@datamweb datamweb force-pushed the fix-deptract-ratelimit branch from 047f071 to 25b614c Compare January 9, 2023 14:32
@datamweb datamweb force-pushed the fix-deptract-ratelimit branch from 1bb7ab7 to f097431 Compare January 9, 2023 14:40
@datamweb
Copy link
Copy Markdown
Collaborator Author

datamweb commented Jan 9, 2023 •
edited
Loading

Looks like it's resolved.
But @kenjis, I think we shouldn't merge this. My goal with these PR was to fix problem deptract, which I don't think can be fixed. As mentioned in this codeigniter4/CodeIgniter4#7065 (comment). Unless there is another reason for merge?
Do you agree with Close?

kenjis
kenjis reviewed Jan 10, 2023
View reviewed changes
Comment thread .github/workflows/deptrac.yml Outdated
deptrac analyze --cache-file=build/deptrac.cache
env:
GITHUB_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copy link
Copy Markdown
Member

@kenjis kenjis Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the last empty line.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jan 10, 2023

@datamweb Yes, this does not seem to work.
I want to fix the GitHub rate limit issue, but now I don't have a clue.

@datamweb
Copy link
Copy Markdown
Collaborator Author

datamweb commented Feb 8, 2023

I close this PR, because now there is no problem for Dependency Tracing.

@datamweb datamweb closed this Feb 8, 2023
@datamweb datamweb deleted the fix-deptract-ratelimit branch February 8, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis left review comments

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@datamweb @kenjis @paulbalandan